Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/ecocredit): improve basket denom validation #1200

Merged
merged 5 commits into from
Jun 23, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Jun 20, 2022

Description

Closes: #1163 / Ref: #1162 (comment)

This pull request separates basket denom regex and custom coin regex and adds basket denom validation.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #1200 (810a068) into master (d7c114c) will decrease coverage by 0.31%.
The diff coverage is 95.23%.

❗ Current head 810a068 differs from pull request most recent head a7116b6. Consider uploading reports for the commit a7116b6 to get more accurate results

@@            Coverage Diff             @@
##           master    #1200      +/-   ##
==========================================
- Coverage   70.35%   70.04%   -0.32%     
==========================================
  Files         234      235       +1     
  Lines       23575    24032     +457     
==========================================
+ Hits        16587    16834     +247     
- Misses       5569     5757     +188     
- Partials     1419     1441      +22     
Flag Coverage Δ
experimental-codecov 70.07% <95.23%> (-0.34%) ⬇️
stable-codecov 64.80% <95.23%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo marked this pull request as ready for review June 21, 2022 04:22
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

types/coin.go Outdated Show resolved Hide resolved
@ryanchristo ryanchristo merged commit 66441cc into master Jun 23, 2022
@ryanchristo ryanchristo deleted the ryan/1163-basket-denom-regex branch June 23, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve basket denom validation and regex
3 participants