Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecocredit): add cancel sell-order command #1274

Merged
merged 7 commits into from
Jul 19, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Jul 19, 2022

Description

Closes: #1273


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #1274 (3a828ef) into master (2e1b6ec) will increase coverage by 2.58%.
The diff coverage is 93.44%.

❗ Current head 3a828ef differs from pull request most recent head 13446e3. Consider uploading reports for the commit 13446e3 to get more accurate results

@@            Coverage Diff             @@
##           master    #1274      +/-   ##
==========================================
+ Coverage   77.48%   80.07%   +2.58%     
==========================================
  Files         213      235      +22     
  Lines       16094    21790    +5696     
==========================================
+ Hits        12471    17449    +4978     
- Misses       2627     3026     +399     
- Partials      996     1315     +319     
Flag Coverage Δ
experimental-codecov 80.13% <93.44%> (+2.54%) ⬆️
stable-codecov 75.28% <93.44%> (-1.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/ecocredit/client/marketplace/tx.go 87.65% <76.47%> (-1.32%) ⬇️
x/ecocredit/client/testsuite/tx_marketplace.go 100.00% <100.00%> (ø)
x/ecocredit/client/tx.go 82.20% <100.00%> (+0.04%) ⬆️
app/experimental_appconfig.go 95.00% <0.00%> (-2.15%) ⬇️
x/group/testdata/tx.go 7.69% <0.00%> (ø)
x/group/server/operations.go 0.00% <0.00%> (ø)
x/group/server/msg_server.go 71.87% <0.00%> (ø)
x/group/server/query_server.go 80.26% <0.00%> (ø)
x/group/msgs.go 57.30% <0.00%> (ø)
x/group/server/server.go 58.76% <0.00%> (ø)
... and 26 more

@aleem1314 aleem1314 marked this pull request as ready for review July 19, 2022 13:17
@ryanchristo ryanchristo added the backport/v4.0.x backport to release/v4.0.x branch label Jul 19, 2022
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Can you add a changelog entry and maybe a separate section for unreleased v4.0?

## [Unreleased v4.0]

### x/ecocredit

#### Added

- [#1274](https://github.com/regen-network/regen-ledger/pull/1274) Add `cancel-sell-order` command

x/ecocredit/client/marketplace/tx.go Outdated Show resolved Hide resolved
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

x/ecocredit/client/marketplace/tx.go Outdated Show resolved Hide resolved
@ryanchristo ryanchristo merged commit 0fa531b into master Jul 19, 2022
@ryanchristo ryanchristo deleted the aleem/tx-cancel-sell-order branch July 19, 2022 18:21
mergify bot pushed a commit that referenced this pull request Jul 19, 2022
* feat(ecocredit): add cancel sell-order command

* chore: fix failing test

* Update x/ecocredit/client/marketplace/tx.go

Co-authored-by: Tyler <[email protected]>

* Update x/ecocredit/client/marketplace/tx.go

Co-authored-by: Ryan Christoffersen <[email protected]>

* chore: add changelog

Co-authored-by: Tyler <[email protected]>
Co-authored-by: Ryan Christoffersen <[email protected]>
(cherry picked from commit 0fa531b)

# Conflicts:
#	CHANGELOG.md
ryanchristo added a commit that referenced this pull request Jul 19, 2022
* feat(ecocredit): add cancel sell-order command (#1274)

* feat(ecocredit): add cancel sell-order command

* chore: fix failing test

* Update x/ecocredit/client/marketplace/tx.go

Co-authored-by: Tyler <[email protected]>

* Update x/ecocredit/client/marketplace/tx.go

Co-authored-by: Ryan Christoffersen <[email protected]>

* chore: add changelog

Co-authored-by: Tyler <[email protected]>
Co-authored-by: Ryan Christoffersen <[email protected]>
(cherry picked from commit 0fa531b)

# Conflicts:
#	CHANGELOG.md

* resolve conflicts

Co-authored-by: MD Aleem <[email protected]>
Co-authored-by: ryanchristo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v4.0.x backport to release/v4.0.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ecocredit(marketplace): add tx command to cancel sell order
3 participants