-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecocredit): add cancel sell-order command #1274
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1274 +/- ##
==========================================
+ Coverage 77.48% 80.07% +2.58%
==========================================
Files 213 235 +22
Lines 16094 21790 +5696
==========================================
+ Hits 12471 17449 +4978
- Misses 2627 3026 +399
- Partials 996 1315 +319
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a changelog entry and maybe a separate section for unreleased v4.0?
## [Unreleased v4.0]
### x/ecocredit
#### Added
- [#1274](https://github.com/regen-network/regen-ledger/pull/1274) Add `cancel-sell-order` command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Co-authored-by: Tyler <[email protected]>
Co-authored-by: Ryan Christoffersen <[email protected]>
* feat(ecocredit): add cancel sell-order command * chore: fix failing test * Update x/ecocredit/client/marketplace/tx.go Co-authored-by: Tyler <[email protected]> * Update x/ecocredit/client/marketplace/tx.go Co-authored-by: Ryan Christoffersen <[email protected]> * chore: add changelog Co-authored-by: Tyler <[email protected]> Co-authored-by: Ryan Christoffersen <[email protected]> (cherry picked from commit 0fa531b) # Conflicts: # CHANGELOG.md
* feat(ecocredit): add cancel sell-order command (#1274) * feat(ecocredit): add cancel sell-order command * chore: fix failing test * Update x/ecocredit/client/marketplace/tx.go Co-authored-by: Tyler <[email protected]> * Update x/ecocredit/client/marketplace/tx.go Co-authored-by: Ryan Christoffersen <[email protected]> * chore: add changelog Co-authored-by: Tyler <[email protected]> Co-authored-by: Ryan Christoffersen <[email protected]> (cherry picked from commit 0fa531b) # Conflicts: # CHANGELOG.md * resolve conflicts Co-authored-by: MD Aleem <[email protected]> Co-authored-by: ryanchristo <[email protected]>
Description
Closes: #1273
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change