refactor: use sdk modules #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanchristo
reviewed
Aug 17, 2022
added 6 commits
August 18, 2022 13:30
technicallyty
commented
Aug 18, 2022
technicallyty
commented
Aug 19, 2022
added 15 commits
August 18, 2022 17:44
|
this is now R4R! @regen-network/ledger-core-dev |
ryanchristo
approved these changes
Aug 22, 2022
Comment on lines
+49
to
+52
| // we append the mock module below in order to bypass the check for validator updates. | ||
| // since we are testing with a fixture with no validators, we must inject a mock module and | ||
| // force it to inject a validator update. | ||
| ff.modules = append(ff.modules, MockModule{}) |
Co-authored-by: Ryan Christoffersen <[email protected]>
…-network/regen-ledger into ty/933-app_module_refactor
aleem1314
reviewed
Aug 23, 2022
|
|
||
| // WeightedOperations returns all the ecocredit module operations with their respective weights. | ||
| // NOTE: This is no longer needed for the modules which uses ADR-33, ecocredit module `WeightedOperations` | ||
| // registered in the `x/ecocredit/server` package. | ||
| func (Module) WeightedOperations(simState module.SimulationState) []simtypes.WeightedOperation { | ||
| return nil | ||
| func (a Module) WeightedOperations(simState module.SimulationState) []simtypes.WeightedOperation { |
There was a problem hiding this comment.
can you also update godoc?
aleem1314
reviewed
Aug 23, 2022
x/data/module/module.go
Outdated
| func (Module) WeightedOperations(simState module.SimulationState) []simtypes.WeightedOperation { | ||
| return nil | ||
| func (a Module) WeightedOperations(simState module.SimulationState) []simtypes.WeightedOperation { | ||
| return a.keeper.WeightedOperations(simState) |
There was a problem hiding this comment.
I think we can directly call simulation.WeightedOperations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
setCustom<Attribute>calls fromRegenAppcosmossdk.io/mathpackage instead of the deprecatedtypes.MathCloses: #933
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change