Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/ecocredit)!: update marketplace submodule architecture #1427

Merged
merged 5 commits into from
Aug 30, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Aug 29, 2022

Description

Ref: #1196

This pull request updates the architecture of the marketplace submodule.

Preview: https://github.com/regen-network/regen-ledger/tree/ryan/1196-marketplace-submodule/x/ecocredit/marketplace


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo marked this pull request as ready for review August 29, 2022 19:11
@ryanchristo ryanchristo requested a review from a team August 29, 2022 19:11
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #1427 (2f90f03) into main (0e5aeb8) will not change coverage.
The diff coverage is 84.89%.

@@           Coverage Diff           @@
##             main    #1427   +/-   ##
=======================================
  Coverage   78.54%   78.54%           
=======================================
  Files         236      236           
  Lines       18109    18109           
=======================================
  Hits        14224    14224           
  Misses       3076     3076           
  Partials      809      809           
Impacted Files Coverage Δ
x/ecocredit/client/query.go 58.65% <0.00%> (ø)
x/ecocredit/client/tx.go 75.00% <0.00%> (ø)
x/ecocredit/marketplace/keeper/keeper.go 100.00% <ø> (ø)
x/ecocredit/marketplace/keeper/utils.go 42.40% <ø> (ø)
x/ecocredit/marketplace/types/v1/codec.go 100.00% <ø> (ø)
...edit/marketplace/types/v1/msg_add_allowed_denom.go 66.66% <ø> (ø)
x/ecocredit/marketplace/types/v1/msg_buy_direct.go 98.03% <ø> (ø)
...edit/marketplace/types/v1/msg_cancel_sell_order.go 83.33% <ø> (ø)
...t/marketplace/types/v1/msg_remove_allowed_denom.go 61.11% <ø> (ø)
x/ecocredit/marketplace/types/v1/msg_sell.go 97.87% <ø> (ø)
... and 27 more

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanchristo ryanchristo requested a review from aleem1314 August 30, 2022 00:23
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ryanchristo ryanchristo merged commit 2ac14ac into main Aug 30, 2022
@ryanchristo ryanchristo deleted the ryan/1196-marketplace-submodule branch August 30, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants