Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/ecocredit)!: update basket submodule architecture #1428

Merged
merged 4 commits into from
Aug 30, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Aug 29, 2022

Description

Ref: #1196

This pull request updates the architecture of the basket submodule.

Preview: https://github.com/regen-network/regen-ledger/tree/ryan/1196-basket-submodule/x/ecocredit/basket


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo marked this pull request as ready for review August 29, 2022 19:14
@ryanchristo ryanchristo requested a review from a team August 29, 2022 19:14
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #1428 (1246fe3) into main (2ac14ac) will decrease coverage by 0.01%.
The diff coverage is 81.61%.

❗ Current head 1246fe3 differs from pull request most recent head 62fcbbf. Consider uploading reports for the commit 62fcbbf to get more accurate results

@@            Coverage Diff             @@
##             main    #1428      +/-   ##
==========================================
- Coverage   78.54%   78.52%   -0.02%     
==========================================
  Files         236      235       -1     
  Lines       18109    18069      -40     
==========================================
- Hits        14224    14189      -35     
+ Misses       3076     3074       -2     
+ Partials      809      806       -3     
Impacted Files Coverage Δ
x/ecocredit/basket/keeper/invariants.go 55.55% <ø> (ø)
x/ecocredit/basket/keeper/keeper.go 100.00% <ø> (ø)
x/ecocredit/basket/keeper/utils.go 62.50% <ø> (ø)
x/ecocredit/basket/types/v1/codec.go 100.00% <ø> (ø)
...ecocredit/basket/types/v1/msg_update_basket_fee.go 41.66% <ø> (ø)
.../ecocredit/basket/types/v1/state_basket_balance.go 100.00% <ø> (ø)
x/ecocredit/basket/types/v1/state_basket_class.go 100.00% <ø> (ø)
x/ecocredit/basket/types/v1/types_date_criteria.go 96.87% <ø> (ø)
x/ecocredit/client/query.go 58.65% <0.00%> (ø)
x/ecocredit/client/tx.go 75.00% <0.00%> (ø)
... and 103 more

@ryanchristo ryanchristo requested a review from aleem1314 August 30, 2022 00:23
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo merged commit a83f474 into main Aug 30, 2022
@ryanchristo ryanchristo deleted the ryan/1196-basket-submodule branch August 30, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants