-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/ecocredit): query balances by batch denom #1450
Conversation
func assertBalanceEqual(ctx context.Context, t *testing.T, k Keeper, received *types.BatchBalanceInfo, balance *api.BatchBalance) { | ||
func (s *baseSuite) assertBalanceEqual(received *types.BatchBalanceInfo, balance *api.BatchBalance) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed this here as i realized it quite a bit un-ergonomic when using it in tests
Codecov Report
@@ Coverage Diff @@
## main #1450 +/- ##
==========================================
- Coverage 78.48% 78.48% -0.01%
==========================================
Files 237 238 +1
Lines 18386 18439 +53
==========================================
+ Hits 14430 14471 +41
- Misses 3118 3126 +8
- Partials 838 842 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog 🙏 |
im getting |
I think hackmd changed the default permissions. You can view now. |
Description
Closes: n/a
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change