Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): query balances by batch denom #1450

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Conversation

technicallyty
Copy link
Contributor

Description

  • adds a query for balances by batch denom

Closes: n/a


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Comment on lines -52 to +51
func assertBalanceEqual(ctx context.Context, t *testing.T, k Keeper, received *types.BatchBalanceInfo, balance *api.BatchBalance) {
func (s *baseSuite) assertBalanceEqual(received *types.BatchBalanceInfo, balance *api.BatchBalance) {
Copy link
Contributor Author

@technicallyty technicallyty Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed this here as i realized it quite a bit un-ergonomic when using it in tests

@technicallyty technicallyty marked this pull request as ready for review August 31, 2022 18:56
@technicallyty technicallyty requested a review from a team August 31, 2022 18:56
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1450 (a36147f) into main (25fecb4) will decrease coverage by 0.00%.
The diff coverage is 77.35%.

@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
- Coverage   78.48%   78.48%   -0.01%     
==========================================
  Files         237      238       +1     
  Lines       18386    18439      +53     
==========================================
+ Hits        14430    14471      +41     
- Misses       3118     3126       +8     
- Partials      838      842       +4     
Impacted Files Coverage Δ
x/ecocredit/base/keeper/query_balance_by_batch.go 66.66% <66.66%> (ø)
x/ecocredit/client/testsuite/grpc.go 100.00% <100.00%> (ø)

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanchristo
Copy link
Member

changelog 🙏

@technicallyty
Copy link
Contributor Author

tACK

im getting 403 forbidden on this link btw 🤔 do i need to be added to a hackmd group or smthn?

@ryanchristo
Copy link
Member

im getting 403 forbidden on this link btw thinking do i need to be added to a hackmd group or smthn?

I think hackmd changed the default permissions. You can view now.

@ryanchristo ryanchristo merged commit 4ef8001 into main Aug 31, 2022
@ryanchristo ryanchristo deleted the ty/balance_by_batch branch August 31, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants