refactor(types): cleanup and organize types package #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1451 +/- ##
==========================================
+ Coverage 78.42% 78.48% +0.05%
==========================================
Files 240 237 -3
Lines 18399 18386 -13
==========================================
Hits 14430 14430
+ Misses 3131 3118 -13
Partials 838 838
|
ryanchristo
approved these changes
Aug 31, 2022
types/testutil/fixture/fixture.go
Outdated
Comment on lines
16
to
18
| "github.com/cosmos/cosmos-sdk/baseapp" | ||
| sdkmodules "github.com/cosmos/cosmos-sdk/types/module" | ||
| "google.golang.org/grpc" |
Comment on lines
+9
to
+16
| type ModuleID struct { | ||
| ModuleName string | ||
| Path []byte | ||
| } | ||
|
|
||
| func (m ModuleID) Address() sdk.AccAddress { | ||
| return AddressHash(m.ModuleName, m.Path) | ||
| } |
There was a problem hiding this comment.
Moving this is a breaking change in the types module. We should add a changelog entry.
Comment on lines
+3
to
+8
| type InvokerFactory func(callInfo CallInfo) (Invoker, error) | ||
|
|
||
| type CallInfo struct { | ||
| Method string | ||
| Caller ModuleID | ||
| } |
There was a problem hiding this comment.
Moving this is a breaking change in the types module. We should add a changelog entry.
added 2 commits
August 31, 2022 13:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
testutildirectory, as it is mainly a test utilityFixtureFactoryimplementation file fromtestutil.gotoimpl.goCloses: n/a
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change