refactor(x/ecocredit): convert class fee argument to optional flag

[aleem1314]

Description

Closes: #1468

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #1475 (637041b) into main (f4f3106) will increase coverage by 0.00%.
The diff coverage is 93.33%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1475   +/-   ##
=======================================
  Coverage   78.32%   78.32%           
=======================================
  Files         250      250           
  Lines       18810    18826   +16     
=======================================
+ Hits        14732    14745   +13     
- Misses       3220     3222    +2     
- Partials      858      859    +1     

Impacted Files	Coverage Δ
x/ecocredit/base/client/tx.go	79.74% <89.28%> (+0.04%)	⬆️
x/ecocredit/basket/client/tx.go	70.85% <100.00%> (ø)
x/ecocredit/client/testsuite/suite.go	96.40% <100.00%> (ø)
x/ecocredit/client/testsuite/tx.go	100.00% <100.00%> (ø)

[technicallyty]

LGTM - just one nit with fee description

[ryanchristo]

Looking good.

If a fee is not required, we should be able to call the command without the flag. After removing the fee and calling the command without the flag, I get the following error:

Error: fee denom cannot be empty: invalid request

Manual test: https://hackmd.io/V3Y6KDgISLCiujh9FXiG7g. Also includes an example of how basket fee flag is not required when no basket fee is set.

[ryanchristo]

tACK but the test is no longer valid.