Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ecocredit basket migration #1842

Merged
merged 6 commits into from
Mar 23, 2023
Merged

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Mar 21, 2023

Description

This pull request adds a state migration to the v5.1 upgrade that fixes the NCT basket on regen-1.

Manual Testing: https://hackmd.io/kOchjSOxRJO8cj_uV9swhg


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ryanchristo ryanchristo added the backport/v5.1.x backport to release/v5.1.x branch label Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #1842 (2e9e257) into main (2caf7db) will decrease coverage by 0.02%.
The diff coverage is 60.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1842      +/-   ##
==========================================
- Coverage   73.26%   73.24%   -0.02%     
==========================================
  Files         230      230              
  Lines       13692    13706      +14     
==========================================
+ Hits        10031    10039       +8     
- Misses       2930     2934       +4     
- Partials      731      733       +2     
Impacted Files Coverage Δ
x/ecocredit/server/migrations.go 26.31% <0.00%> (ø)
x/ecocredit/migrations/v4/state.go 90.08% <66.66%> (-4.31%) ⬇️

@ryanchristo
Copy link
Member Author

pending #1812

@ryanchristo ryanchristo marked this pull request as ready for review March 23, 2023 16:09
@ryanchristo ryanchristo requested a review from a team March 23, 2023 16:09
@ryanchristo ryanchristo merged commit a1eddf1 into main Mar 23, 2023
@ryanchristo ryanchristo deleted the ryan/v5.1-state-migration-2 branch March 23, 2023 18:33
mergify bot pushed a commit that referenced this pull request Mar 23, 2023
ryanchristo added a commit that referenced this pull request Mar 23, 2023
@ryanchristo ryanchristo mentioned this pull request Mar 23, 2023
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v5.1.x backport to release/v5.1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants