WIP on ADR 033 x/bank #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgimeno
reviewed
Dec 3, 2020
| serverMod.RegisterInterfaces(mm.cdc.InterfaceRegistry()) | ||
| } | ||
|
|
||
| for _, mod := range modules { |
There was a problem hiding this comment.
you can use the same loop as before I think :)
There was a problem hiding this comment.
I want to make sure all interface types are registered first
…en-ledger into aaronc/bank-v2
|
@aaronc is this something that should be closed? Or are you planning to continue working on this? |
|
We can close. Future work will happen in the SDK when we have enough dev bandwidth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.