Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): Retire ORM #826

Merged
merged 9 commits into from
Mar 9, 2022
Merged

feat(x/ecocredit): Retire ORM #826

merged 9 commits into from
Mar 9, 2022

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Mar 3, 2022

Description

adds retire method with ORM

ref: #696


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few minor suggestions. Pre-approving.

x/ecocredit/server/core/retire.go Outdated Show resolved Hide resolved
x/ecocredit/server/core/retire_test.go Outdated Show resolved Hide resolved
x/ecocredit/server/core/retire_test.go Outdated Show resolved Hide resolved
x/ecocredit/server/core/retire_test.go Show resolved Hide resolved
x/ecocredit/server/core/retire_test.go Outdated Show resolved Hide resolved
x/ecocredit/server/core/retire_test.go Outdated Show resolved Hide resolved
@amaury1093 amaury1093 self-assigned this Mar 8, 2022
@technicallyty technicallyty enabled auto-merge (squash) March 8, 2022 20:37
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One improvement we could do is group the credits by batch in the loop, and do store reads/writes by batch, to save some gas. But okay to leave it as is for now.

@technicallyty technicallyty merged commit 3da83f1 into master Mar 9, 2022
@technicallyty technicallyty deleted the ty/696-retire branch March 9, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants