-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/ecocredit): add basket years in the past #874
Conversation
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
==========================================
- Coverage 73.85% 67.02% -6.84%
==========================================
Files 173 167 -6
Lines 22233 19716 -2517
==========================================
- Hits 16421 13214 -3207
- Misses 4671 5426 +755
+ Partials 1141 1076 -65
Flags with carried forward coverage won't be shown. Click here to find out more. |
Waiting on #870 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, test just needs fixing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also work on testing the scenario outlines? That would inspire more confidence in the correctness
Opening a separate pull request for testing the scenario outlines. I was hoping to update the basket acceptance tests (#895) before implementing them but it will be good to start writing out the tests to better understand how they are executed. Update: Opened #902 |
Description
Closes: #820
Add date criteria option
years_in_the_past
and allow for data criteria not to be set.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change