Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): add basket years in the past #874

Merged
merged 26 commits into from
Mar 16, 2022

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Mar 10, 2022

Description

Closes: #820

Add date criteria option years_in_the_past and allow for data criteria not to be set.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #874 (44b246b) into master (3f1dff4) will decrease coverage by 6.83%.
The diff coverage is 100.00%.

❗ Current head 44b246b differs from pull request most recent head 1e394b1. Consider uploading reports for the commit 1e394b1 to get more accurate results

@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
- Coverage   73.85%   67.02%   -6.84%     
==========================================
  Files         173      167       -6     
  Lines       22233    19716    -2517     
==========================================
- Hits        16421    13214    -3207     
- Misses       4671     5426     +755     
+ Partials     1141     1076      -65     
Flag Coverage Δ
experimental-codecov ?
stable-codecov 67.02% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ryanchristo ryanchristo changed the title feat(x/ecocredit): add basket fixed start date feat(x/ecocredit): add basket years in the past Mar 11, 2022
@ryanchristo
Copy link
Member Author

ryanchristo commented Mar 11, 2022

Waiting on #870

@ryanchristo ryanchristo marked this pull request as ready for review March 11, 2022 23:46
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, test just needs fixing

Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also work on testing the scenario outlines? That would inspire more confidence in the correctness

@ryanchristo
Copy link
Member Author

ryanchristo commented Mar 16, 2022

Can we also work on testing the scenario outlines? That would inspire more confidence in the correctness

Opening a separate pull request for testing the scenario outlines. I was hoping to update the basket acceptance tests (#895) before implementing them but it will be good to start writing out the tests to better understand how they are executed.

Update: Opened #902

@ryanchristo ryanchristo enabled auto-merge (squash) March 16, 2022 14:53
@ryanchristo ryanchristo merged commit 9f27542 into master Mar 16, 2022
@ryanchristo ryanchristo deleted the ryan/820-basket-start-date branch March 16, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update basket date criteria
5 participants