Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ecocredit): migrate client to target v1 #901

Merged
merged 29 commits into from
Apr 12, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Mar 16, 2022

Description

Ref: #876
closes: #663


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aleem1314 aleem1314 marked this pull request as ready for review April 11, 2022 10:34
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@e3816ca). Click here to learn what that means.
The diff coverage is 27.02%.

❗ Current head a26480c differs from pull request most recent head 88232d6. Consider uploading reports for the commit 88232d6 to get more accurate results

@@            Coverage Diff            @@
##             master     #901   +/-   ##
=========================================
  Coverage          ?   59.18%           
=========================================
  Files             ?      215           
  Lines             ?    23496           
  Branches          ?        0           
=========================================
  Hits              ?    13905           
  Misses            ?     8288           
  Partials          ?     1303           
Flag Coverage Δ
experimental-codecov 59.07% <27.02%> (?)
stable-codecov 52.82% <27.02%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

x/ecocredit/client/marketplace/query.go Outdated Show resolved Hide resolved
x/ecocredit/client/marketplace/tx.go Outdated Show resolved Hide resolved
Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A couple comments and suggestions.

x/ecocredit/client/marketplace/query.go Outdated Show resolved Hide resolved
x/ecocredit/client/utils/util.go Outdated Show resolved Hide resolved
x/ecocredit/client/marketplace/query.go Show resolved Hide resolved
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@technicallyty
Copy link
Contributor

technicallyty commented Apr 12, 2022

looks like theres an import error somewhere

FAIL	github.com/regen-network/regen-ledger/v3/app/testsuite [setup failed]
x/ecocredit/client/testsuite/tx.go:26:2: no required module provides package github.com/regen-network/regen-ledger/x/ecocredit/client/utils; to add it:
	go get github.com/regen-network/regen-ledger/x/ecocredit/client/utils

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One minor change needed for tests to pass. Will commit and merge.

types/timestamp_test.go Outdated Show resolved Hide resolved
@ryanchristo ryanchristo merged commit 2818838 into master Apr 12, 2022
@ryanchristo ryanchristo deleted the aleem/876-ecocredit-client branch April 12, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a function to format date in Regen Ledger
3 participants