refactor(x/data): update sign to attest #927
Conversation
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
==========================================
- Coverage 72.46% 72.37% -0.09%
==========================================
Files 194 194
Lines 22880 22880
==========================================
- Hits 16579 16559 -20
- Misses 5064 5076 +12
- Partials 1237 1245 +8
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -10,18 +10,18 @@ option go_package = "github.com/regen-network/regen-ledger/x/data"; | |||
|
|
|||
| // Msg is the regen.data.v1alpha1 Msg service | |||
| service Msg { | |||
| // AnchorData "anchors" a piece of data to the blockchain based on its secure | |||
| // Anchor "anchors" a piece of data to the blockchain based on its secure | |||
There was a problem hiding this comment.
| // Anchor "anchors" a piece of data to the blockchain based on its secure | |
| // Anchor a piece of data to the blockchain based on its secure |
There was a problem hiding this comment.
Anchor is the name of the method here, not a verb.
proto/regen/data/v1/tx.proto
Outdated
| // signers and those signers will be appended to the list of signers. | ||
| rpc SignData(MsgSignData) returns (MsgSignDataResponse); | ||
| // Attest can be called multiple times for the same content hash with different | ||
| // attestors and those attestors will be appended to the list of attestors. |
There was a problem hiding this comment.
What happens if the same attestor attests same data multiple times? Is it overwritten?
There was a problem hiding this comment.
In the current implementation, we don't do anything if an attestor attempts to attest to the same data. The original attestation with the original timestamp is not overwritten and no new attestation is added. I can add a note here.
Opened #932 for tracking. |
Description
Closes: #637
Updates the data module to use attestation terminology.
SignDatatoAttestSignertoAttestorAlso changes
AnchorDatatoAnchor.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change