feat(ecocredit/core): add issuance date to BatchInfo #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #936 +/- ##
==========================================
- Coverage 73.22% 72.42% -0.81%
==========================================
Files 196 194 -2
Lines 23115 22895 -220
==========================================
- Hits 16927 16582 -345
- Misses 4904 5062 +158
+ Partials 1284 1251 -33
Flags with carried forward coverage won't be shown. Click here to find out more. |
ryanchristo
approved these changes
Mar 25, 2022
Co-authored-by: Ryan Christoffersen <[email protected]>
aleem1314
reviewed
Mar 27, 2022
| @@ -132,6 +132,9 @@ message BatchInfo { | |||
| // end_date is the end of the period during which this credit batch was | |||
| // quantified and verified. | |||
| google.protobuf.Timestamp end_date = 6; | |||
|
|
|||
| // issuance_date is the timestamp when the credit batch was issued. | |||
| google.protobuf.Timestamp issuance_date = 7; | |||
There was a problem hiding this comment.
This is a state-breaking change. Let's add an entry for this in #678.
aleem1314
approved these changes
Mar 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EventCreateBatchandBatchInfoCloses: #680
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change