Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include LICENSE file in the installed node_modules #179

Closed
4 tasks done
MarkAshraf96 opened this issue Sep 27, 2024 · 2 comments · Fixed by #180
Closed
4 tasks done

Include LICENSE file in the installed node_modules #179

MarkAshraf96 opened this issue Sep 27, 2024 · 2 comments · Fixed by #180
Labels
💪 phase/solved Post is done

Comments

@MarkAshraf96
Copy link
Contributor

Initial checklist

Problem

Including the license file in the installed node_modules, makes the packages compatible with license checkers and attribution file generators, that a lot of developers need for generating copyrights/attribution files.

Solution

Copy the license file into all packages.

Alternatives

Nothing on my mind.
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 27, 2024
@wooorm
Copy link
Member

wooorm commented Sep 27, 2024

Will you do a PR for this too? Much appreciated!

@MarkAshraf96 MarkAshraf96 mentioned this issue Sep 27, 2024
Merged
5 tasks
@MarkAshraf96
Copy link
Contributor Author

Yes, done 😄

wooorm pushed a commit that referenced this issue Sep 27, 2024
@MarkAshraf96
Add license file to packages
e578a2b 
Closes GH-179.
Closes GH-180.

Reviewed-by: Christian Murphy <[email protected]>
Reviewed-by: Titus Wormer <[email protected]>
@wooorm wooorm added the 💪 phase/solved Post is done label Sep 27, 2024
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add license file to packages MarkAshraf96/rehype
2 participants
@wooorm @MarkAshraf96