-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rehype-mathml
to list of plugins
#186
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 154 163 +9
=========================================
+ Hits 154 163 +9 ☔ View full report in Codecov by Sentry. |
Nice!
|
Thank you for your comments.
Based on the advice given in this pull request, I was planning to make some adjustments and then release stable 1.0.0. Is it necessary to release stable 1.0.0 immediately?
Do I need to describe the reasons for using temml? Or do I need to add the main options of temml to the README? Links to temml's options have already been included.
I wasn't aware of hast-util-from-html-isomorphic. I will make the necessary corrections. |
No — but: this list is for recommended things; that conflicts with software in beta
I was missing the first, yes, reasons to use this package over |
I have also completed the fix for hast-util-from-html-isomorphic, and after determining that the main code is sufficient, I have released stable 1.0.0. As you pointed out, the README lacked descriptions of the strengths of this plugin, which uses MathML, and the reasons for using |
Thanks! |
This comment has been minimized.
This comment has been minimized.
Thanks @Daiji256! 👋
|
@ChristianMurphy |
Initial checklist
Description of changes
Add
rehype-mathml
to list of pluginsRendering math with MathML is lightweight and supported by many browsers.
I wanted a plugin for rendering math with MathML, similar to
rehype-mathjax
andrehype-katex
, so I have createdrehype-mathml
.npm:
@daiji256/rehype-mathml