Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CLI client work on Windows #29

Closed
reibitto opened this issue Jul 27, 2020 · 3 comments · Fixed by #85
Closed

Make CLI client work on Windows #29

reibitto opened this issue Jul 27, 2020 · 3 comments · Fixed by #85

Comments

@reibitto
Copy link
Owner

The blocker for this was this lanterna issue:
mabe02/lanterna#422

But it seems like it's been addressed (at least partially?). It's a matter of trying it on Windows and seeing what happens.

@rednoah
Copy link

rednoah commented Aug 4, 2020

Fully functional as far as I can tell. You'll need to build from source for testing right now though, since none of the maven builds include the new JNA implementation yet.

@reibitto
Copy link
Owner Author

reibitto commented Aug 4, 2020

Thanks @rednoah.

Just to make sure I understood, you mean that lanterna's Windows implementation works as far you can tell? Or did you mean you tried it with Command Center and that it worked?

I'll be setting up my Windows box soon, so I could be try it out myself too.

@reibitto
Copy link
Owner Author

Looks like it works. Thanks!

I merged the Windows PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants