-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper Windows support #85
Conversation
* Improve Windows support * Attempt JFrame fixes * Fix Windows focus and browser issue * scalafmt
Hey. I started a similar project (https://github.com/sne11ius/batarang) - mainly just to try and use new tech. |
No, unfortunately the native image build for this project on Windows doesn't work yet. 😟 I believe the issue comes from lanterna and how the Windows terminal requires JNA. I haven't investigated how to get JNA + native-image working together, but it sounds like it would be difficult and support for it isn't planned. Maybe it would be better to come at it from the other direction and remove the JNA dependency from lanterna itself. I think only 1 or 2 classes use JNA. Maybe JNI plays better with native-image. That would be something worth looking into I think. |
Actually, it's weird. At one point it was working. Maybe I'm mistaken on what the issue actually is. I might need to create a small sample project and check again. |
Alright, sorry, I think I remember now. So this PR adds Windows support and that works with a normal JVM. Before this PR even that didn't work. But I'm pretty sure a native-image build for Windows never worked. That would make sense. So yeah, I'm pretty sure JNA is the cause. |
Ah thanks. I think I am like 80%ish of the way there. But jna & graalvm native image seem to really not work together well. |
Closes #29
I finally tried Command Center on a Windows machine and a bunch of things weren't working the way they were supposed to. This fixes everything I found. Both the cli-client and daemon should work properly now.