Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper Windows support #85

Merged
merged 4 commits into from
Aug 16, 2020
Merged

Add proper Windows support #85

merged 4 commits into from
Aug 16, 2020

Conversation

reibitto
Copy link
Owner

Closes #29

I finally tried Command Center on a Windows machine and a bunch of things weren't working the way they were supposed to. This fixes everything I found. Both the cli-client and daemon should work properly now.

@reibitto reibitto merged commit 2a5dda8 into master Aug 16, 2020
@reibitto reibitto deleted the windows-support branch August 16, 2020 08:53
duester pushed a commit to duester/command-center that referenced this pull request Aug 18, 2020
* Improve Windows support

* Attempt JFrame fixes

* Fix Windows focus and browser issue

* scalafmt
@sne11ius
Copy link

sne11ius commented Jan 5, 2021

Hey. I started a similar project (https://github.com/sne11ius/batarang) - mainly just to try and use new tech.
I managed to create a github action for creatting native executables via graalvm. The linux-version actually works fine, too ;)
I understand you have a working windows build? Did you also try to create a native image via graalvm for windows? If so ... did it work?

@reibitto
Copy link
Owner Author

reibitto commented Jan 5, 2021

No, unfortunately the native image build for this project on Windows doesn't work yet. 😟 I believe the issue comes from lanterna and how the Windows terminal requires JNA.

I haven't investigated how to get JNA + native-image working together, but it sounds like it would be difficult and support for it isn't planned.

Maybe it would be better to come at it from the other direction and remove the JNA dependency from lanterna itself. I think only 1 or 2 classes use JNA. Maybe JNI plays better with native-image. That would be something worth looking into I think.

@reibitto
Copy link
Owner Author

reibitto commented Jan 5, 2021

Actually, it's weird. At one point it was working. Maybe I'm mistaken on what the issue actually is. I might need to create a small sample project and check again.

@reibitto
Copy link
Owner Author

reibitto commented Jan 5, 2021

Alright, sorry, I think I remember now. So this PR adds Windows support and that works with a normal JVM. Before this PR even that didn't work. But I'm pretty sure a native-image build for Windows never worked. That would make sense. So yeah, I'm pretty sure JNA is the cause.

@sne11ius
Copy link

sne11ius commented Jan 6, 2021

Ah thanks. I think I am like 80%ish of the way there. But jna & graalvm native image seem to really not work together well.
The last 20% are going to be tough I guess ;) - Not sure if I'm willing to put myself through this...
Anyway, thank you. I'll let you know if I ever happen to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CLI client work on Windows
2 participants