Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address check issues #13

Merged
merged 1 commit into from
Sep 23, 2024
Merged

address check issues #13

merged 1 commit into from
Sep 23, 2024

Conversation

elray1
Copy link
Contributor

@elray1 elray1 commented Sep 23, 2024 •
edited
Loading

This addresses all problems identified by R CMD CHECK other than unused global variables, which I leave to a separate PR.

Specifically:

  • remove unused package imports (for package imports that are only used in examples, put them in suggests)
  • clean up license
  • added a period to end up description line

Also updated authors along the way.

@elray1 elray1 requested a review from lshandross September 23, 2024 15:51
lshandross
lshandross approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@lshandross lshandross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@elray1 elray1 merged commit 33f185a into main Sep 23, 2024
6 checks passed
@elray1 elray1 deleted the check_fixes branch September 23, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lshandross lshandross lshandross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elray1 @lshandross