Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ellipsis] Enhance SQL Syntax Matching with AST Comparison #60

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ellipsis-dev[bot]
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot commented May 16, 2024

This change addresses review comments left by @yisz on PR #59: Add SQL Metrics Implementation

⚠️ We couldn't build/test your project to verify our changes. Add a Dockerfile to significantly improve code quality.

Summary:

Enhanced the SQLSyntaxMatch metric in continuous_eval/metrics/code/sql/sql_deterministic_metrics.py by replacing string comparison with AST comparison for more accurate SQL query evaluation.

Key points:

  • Updated SQLSyntaxMatch in continuous_eval/metrics/code/sql/sql_deterministic_metrics.py.
  • Replaced string comparison with AST comparison in __call__ method.
  • Added compare_ast method for AST comparison (placeholder implementation).

You can configure Ellipsis to address comments with a direct commit or a side PR, see docs.


Something look wrong?: If this Pull Request doesn't address the comments left on the above pull request, create a new PR review with more details. For more information, check the documentation.

Generated with ❤️ by ellipsis.dev

@ellipsis-dev ellipsis-dev bot requested a review from yisz May 16, 2024 20:48
Base automatically changed from add-sql-metrics to main May 22, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants