Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatible force_list and force_tuple #129

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Python 3 compatible force_list and force_tuple #129

merged 1 commit into from
Oct 8, 2019

Conversation

alexandrevicenzi
Copy link
Contributor

Allow force_list and force_tuple to convert dict_keys
to list and/or tuple.

This fixes #128.

@coveralls
Copy link

coveralls commented Oct 4, 2019

Pull Request Test Coverage Report for Build 162

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 53.272%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kobo/shortcuts.py 6 7 85.71%
Totals Coverage Status
Change from base Build 158: 0.007%
Covered Lines: 3175
Relevant Lines: 5960

💛 - Coveralls

Allow force_list and force_tuple to convert dict_keys
to list and/or tuple.

This fixes #128.
@alexandrevicenzi alexandrevicenzi merged commit 9339743 into release-engineering:master Oct 8, 2019
@alexandrevicenzi alexandrevicenzi deleted the dict_keys branch October 8, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

force_list does not return a list if argument is dict_keys type
3 participants