worker: finish all opened tasks and reexec on SIGHUP
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzaoral
force-pushed
the
reload-on-sighup
branch
from
fc3ca34 to
d3790bf
Compare
lzaoral
added a commit
to lzaoral/openscanhub
that referenced
this pull request
Jan 15, 2024
rohanpm
approved these changes
Jan 16, 2024
lzaoral
force-pushed
the
reload-on-sighup
branch
from
d3790bf to
4bcc950
Compare
lzaoral
force-pushed
the
reload-on-sighup
branch
from
4bcc950 to
a122bc6
Compare
This feature implements safe reloading of updated configuration or updated source code, e.g. with `systemctl reload`. The reexec won't be performed when SIGHUP is followed by SIGTERM, SIGINT or explicit shutdown by the `ShutdownWorker` task. The unit tests must use `mock.ANY` instead of the actual signal handler because it is impossible to reference a nested closure outside of its own scope.
lzaoral
force-pushed
the
reload-on-sighup
branch
from
a122bc6 to
7245924
Compare
lzaoral
added a commit
to lzaoral/openscanhub
that referenced
this pull request
Mar 15, 2024
rohanpm
approved these changes
Mar 18, 2024
lzaoral
added a commit
to lzaoral/openscanhub
that referenced
this pull request
Mar 20, 2024
This requires python3-kobo-worker 0.36.0 or newer. Related: release-engineering/kobo#245
lzaoral
added a commit
to lzaoral/openscanhub
that referenced
this pull request
Mar 28, 2024
This requires python3-kobo-worker 0.36.0 or newer. Related: release-engineering/kobo#245
lzaoral
added a commit
to lzaoral/openscanhub
that referenced
this pull request
May 3, 2024
This requires python3-kobo-worker 0.36.0 or newer. Related: release-engineering/kobo#245
lzaoral
added a commit
to lzaoral/openscanhub
that referenced
this pull request
May 3, 2024
This requires python3-kobo-worker 0.36.1 or newer. Related: release-engineering/kobo#245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature implements safe reloading of updated configuration or updated source code, e.g. with
systemctl reload.