test: test logging thread class. #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanpm
reviewed
Oct 26, 2018
|
|
||
| class TestLoggingThread(unittest.TestCase): | ||
|
|
||
| @unittest.skipIf(six.PY3, 'Encoding errors on Python 3') |
There was a problem hiding this comment.
Would you be able to file a bug about that?
There was a problem hiding this comment.
Yes, but on GitHub we already have a bug report about py3.
There was a problem hiding this comment.
Then you can mention it in the text here.
There was a problem hiding this comment.
Created issue #66 for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for LoggingThread and LoggingIO class.