Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure version is valid before passing it to semver #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ygrishajev
Copy link

There is a use case when using a custom tagPrefix.
In my monorepo I'm trying to implement semver prerelease flow with a custom prefix like so:

<app>/v<semver>-alfa.0 -> <app>/v<semver>-alfa.1 -> <app>/v<semver>-beta.0 -> <app>/v<semver>

It works fine till first stable version is created. After this new pre-release ones are failing as tags are technically invalid according to semver.

This PR attempts to address this issue.

I'd be happy to discard it if there is an existing way to address this.

@webpro
Copy link
Contributor

webpro commented Oct 21, 2024

After this new pre-release ones are failing as tags are technically invalid according to semver.

Although tags don't require semver validness, allowing this in a plugin might cause all sorts of issues, also in release-it core. Didn't investigate all the way through, but tbh doesn't come across as a great idea initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants