[fix] Compute embedding cosine distance #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distance between embeddings is typically cosine distance. That is the complement of the dot product over the product of vector norm/magnitude/length. 1 - (a dot b) / (||a|| * ||b|)
It looks like the terminology on the denominator might have been ambiguous so it was implemented as product of the length of the embedding arrays, which is always the same and produced incorrect results.
This is a more typical implementation and produces verifiably correct results. The tests have been updated to check these.
Test plan: