This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Feature/api v3 #43
Merged
Feature/api v3 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring for sure required
|
@kamilbednarz At a quick glance this looks fine to me. I'm a bit out of touch with Ruby practices - is there a way to release a beta version of this and let people test it? |
|
Sure, I'll release a beta version and test it with a project for my client. |
|
Hey @relrod, I created a new gem version, can you either push it to rubygems, or allow me to push new versions (My email is in my github profile)? The tag is: |
|
@kamilbednarz Added you on rubygems. Thanks so much for your work on this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @relrod,
here is a draft of a pull request that covers the migration to API v3.
I also refactored the code (separated the logic responsible for HTTP requests/responses) and the organized specs (mostly just wrapped them in
describeblocks by method).