Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust's ranges are exclusive of the last value #743

Merged
merged 1 commit into from
May 15, 2018

Conversation

db48x
Copy link
Collaborator

@db48x db48x commented May 15, 2018

Just like the C code we ported it from.

In my defense, I just blindly copied this code from Sean, and didn't
double-check it. Fixes #742

Just like the C code we ported it from.

In my defense, I just blindly copied this code from Sean, and didn't
double-check it. Fixes remacs#742
@db48x db48x requested a review from shaleh May 15, 2018 00:53
Copy link
Collaborator

@shaleh shaleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I did mention I had not tested the code, right? :-)

@shaleh shaleh merged commit 684dcc3 into remacs:master May 15, 2018
@db48x
Copy link
Collaborator Author

db48x commented May 15, 2018

Technically you did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants