Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to TypeScript #1123

Merged
merged 1 commit into from
Oct 29, 2023
Merged

refactor: migrate to TypeScript #1123

merged 1 commit into from
Oct 29, 2023

Conversation

remarkablemark
Copy link
Owner

@remarkablemark remarkablemark commented Oct 29, 2023

What is the motivation for this pull request?

refactor: migrate to TypeScript

BREAKING CHANGE: CommonJS imports require the .default key

Closes #1000
Closes #1121

What is the current behavior?

Vanilla JavaScript

What is the new behavior?

TypeScript

Checklist:

@remarkablemark remarkablemark added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 29, 2023
@remarkablemark remarkablemark self-assigned this Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #1123 (713c548) into master (1fcb059) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          153       153           
  Branches        46        50    +4     
=========================================
  Hits           153       153           
Files Coverage Δ
src/attributes-to-props.ts 100.00% <100.00%> (ø)
src/dom-to-react.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/utilities.ts 100.00% <100.00%> (ø)
test/data/html.ts 100.00% <100.00%> (ø)
test/data/index.ts 100.00% <100.00%> (ø)
test/data/svg.ts 100.00% <100.00%> (ø)
test/helpers/index.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 10.2 KB (+3.02% 🔺) 205 ms (+3.02% 🔺) 47 ms (+19.73% 🔺) 251 ms

BREAKING CHANGE: CommonJS imports require the `.default` key

Closes #1000
@remarkablemark remarkablemark merged commit 4255a10 into master Oct 29, 2023
@remarkablemark remarkablemark deleted the refactor/typescript branch October 29, 2023 15:19
@remarkablemark
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to TypeScript
1 participant