-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support MathJax #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for working on this!
A couple questions though:
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I think this is ready, only one more tip to not add CSS if it’s unneeded.
Thank you for nice comments. I added them. |
Btw seems like you haven’t set up GitHub to connect itself to Git: https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address, so unless you do that your contribution won’t be assigned to you. |
If you don’t mind, let me know and I’ll merge right away, otherwise, let me know when you set that up and then I’ll merge! |
Thanks again for informing me. I fix this in a day and send message you. |
I combined all commits into one, and updated email address. Because I like this project and ecosystem, I keep to contribute this package. Could you add me as collaborator to this repository. I can follow the latest version of MathJax and other vulnerabilities. I'm planning to use this package to write academic document, and I want to use latest feature of MathJax in my project. |
Thanks for all your work! I can’t publish yet: Ir1d/rehype-mathjax#1.
Awesome! We’d be grateful for your help! We do have policies in place regarding membership, described here: https://github.com/unifiedjs/collective/blob/master/members.md. As we’ve just met, and we can work together already without extra GitHub rights, I think we should first do that for a while! Does that make sense? Please do let me know if you have questions about this policy. |
I got it. I wait to solve the duplication of package name.
I agreed. I'm so moved by that members policy, which is a ideal style for open source community. |
Should we make scope in npm? unifiedjs/ideas#8 |
Hi there,
Thank you for great plugin! As I want to use MathJaX instead of KaTeX in this plugin, I create this request. This plugin insert SVG and its stylesheet to each nodes, that SVG is generated by MathJax v3.
Cheers!