This repository has been archived by the owner on Jun 13, 2019. It is now read-only.
Fix focus and exposure state after focusing at point #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if currentDevice.focusMode == AVCaptureFocusMode.Locked { | ||
| currentDevice.focusMode = AVCaptureFocusMode.AutoFocus | ||
| } else { | ||
| currentDevice.focusMode = AVCaptureFocusMode.ContinuousAutoFocus |
There was a problem hiding this comment.
One strange thing I noticed in AVFoundation is that you have to explicitly call currentDevice.focusMode = AVCaptureFocusMode.ContinuousAutoFocus even if is already in .ContinuousAutoFocus. Otherwise the focus action simply won't work.
Any explanation for that ? 😶
There was a problem hiding this comment.
I have no idea. I didn't play enough with the API yet, to notice something. 🙃
|
Thank you so much for your PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
focus:atPointmethod should not override the current focus/exposure method.For example it results in
ContinuousAutoFocusbeing changed toAutoFocus.AutoFocuschanges toLockedautomatically after it focuses, so after using thefocus atPointmethod the focus and exposure is locked resulting in poor image.