Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version breaks router replace #3807

Closed
bayleedev opened this issue Sep 12, 2016 · 2 comments
Closed

New version breaks router replace #3807

bayleedev opened this issue Sep 12, 2016 · 2 comments

Comments

@bayleedev
Copy link

Version

2.8.0

Test Case

http://jsbin.com/ciqurodeda/1/edit?html,js,output

Steps to reproduce

  • Replace query with string: replace({ pathname: '/', query: { name: 'meow' } })

Expected Behavior

  • Assert name is in url once
  • Assert value comes back as string meow

Actual Behavior

  • Assert name is in url twice
  • Assert value comes back as array ['meow', 'meow']

Additional Information

This behavior does not happen in 2.7.0 and is likely related to this line.
taion added a commit that referenced this issue Sep 12, 2016
@taion
Fix redirects
f80e284 
Only need to create the location in match.

Fixes #3807
@taion taion mentioned this issue Sep 12, 2016
Merged
timdorr pushed a commit that referenced this issue Sep 13, 2016
@taion @timdorr
Fix redirects (#3808)
6b231fb 
Only need to create the location in match.

Fixes #3807
@taion
Copy link
Contributor

taion commented Sep 13, 2016

Fixed in 2.8.1

@bayleedev
Copy link
Author

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bayleedev @taion