Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight refactor to partial hydration to leverage state.initialized properly #11094

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

brophdawg11
Copy link
Contributor

The previous approach felt wrong since we were hijacking initialized incorrectly. state.initialized is back to meaning "do I need to run loaders during router.initialize()" and we use the future flag to bypass rendering fallbackElement

Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: 2b34fd0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
react-router-dom Patch
react-router Patch
@remix-run/router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR


// TODO: Probably want these running against RouterProvider in react-router too?
// Look into extracting the setState stuff and sharing the subscriber,
// layout effect, navigator, render stuff
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to partial-hydration-test and these now also run against the react-router RouterProvider along with createMemoryRouter

@brophdawg11 brophdawg11 merged commit fe3c071 into release-next Dec 6, 2023
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/partial-hydration-refactor branch December 6, 2023 15:43
Copy link
Contributor

github-actions bot commented Dec 6, 2023

🤖 Hello there,

We just published version 6.21.0-pre.3 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.21.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant