Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export proper dom versions #12132

Merged
merged 10 commits into from
Oct 16, 2024
Merged

Export proper dom versions #12132

merged 10 commits into from
Oct 16, 2024

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Oct 15, 2024 •
edited
Loading

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 421d5cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

brophdawg11
brophdawg11 commented Oct 16, 2024
View reviewed changes
packages/react-router-fs-routes/rollup.config.js
}),
typescript({
tsconfig: path.join(__dirname, "tsconfig.json"),
exclude: ["__tests__"],
noEmitOnError: !WATCH,
noForceEmit: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to avoid TS incorrectly exporting a CJS module during the rollup esm build

brophdawg11
brophdawg11 commented Oct 16, 2024
View reviewed changes
packages/react-router-node/rollup.config.js
@@ -30,8 +30,7 @@ module.exports = function rollup() {
output: {
banner: createBanner(name, version),
dir: OUTPUT_DIR,
entryFileNames: "[name].mjs",
format: "esm",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the esm build for react-router-node

@brophdawg11 brophdawg11 merged commit cd47396 into dev Oct 16, 2024
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/rr-dom branch October 16, 2024 20:35
@brophdawg11 brophdawg11 mentioned this pull request Oct 16, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 7.0.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.28.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.28.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brophdawg11