Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nuke rollup, configure export conditions #12136

Merged
merged 20 commits into from
Oct 23, 2024
Merged

Conversation

jacob-ebey
Copy link
Member

@jacob-ebey jacob-ebey commented Oct 16, 2024

feat: nuke rollup into oblivion in favor of tsup

This PR does quite a bit yet nothing at the same time:

  • Removes Rollup in favor of tsup to easily produces ESM and CJS modules and types (ran per package now, coordinated with pnpm run --recursive
  • Updates conditions to be "default" instead of "require" as the last condition as we are a CJS module and having a "default" condition is good practice
  • Updates conditions to add support for "node" and "module-sync" to avoid dual module hazards by either always resolving to ESM when require("esm") is available, otherwise always the CJS versions.
  • adds https://github.com/google/wireit for per package build caches (dropped subsequent CI time by quite a bit and makes running integration tests locally a lot better by only re-building the changed packages)

feat: nuke rollup into oblivion in favor of tsup
Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: 9495f7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 mentioned this pull request Oct 17, 2024
@jacob-ebey jacob-ebey merged commit 2d5924f into dev Oct 23, 2024
8 checks passed
@jacob-ebey jacob-ebey deleted the esm_configuration branch October 23, 2024 20:37
@jacob-ebey jacob-ebey changed the title feat: configure export conditions properly feat: nuke rollup, configure export conditions Oct 23, 2024
Copy link
Contributor

🤖 Hello there,

We just published version 7.0.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.28.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.28.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.1.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants