-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Node 18 and installGlobals #12171
Conversation
🦋 Changeset detectedLatest commit: f1fcf52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
||
if (!globalThis.fetch) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure why this is still needed - but unit tests fail without it - maybe a jsdom
issue?
> pnpm test packages/react-router/__tests__/router/navigation-test.ts
...
● navigations › navigation states › loader submission + redirect
ReferenceError: Request is not defined
4978 | }
4979 |
> 4980 | return new Request(url, init);
| ^
4981 | }
4982 |
4983 | function convertFormDataToSearchParams(formData: FormData): URLSearchParams {
at createClientSideRequest (lib/router/router.ts:4980:3)
at createClientSideRequest (lib/router/router.ts:1560:19)
at Object.startNavigation [as navigate] (lib/router/router.ts:1411:11)
at Object.navigate (__tests__/router/utils/data-router-setup.ts:642:19)
at Object.navigate (__tests__/router/navigation-test.ts:1250:23)
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Per https://nodejs.org/en/about/previous-releases:
This means we no longer need an
installGlobals
method becausefetch
is stable in Node 20 🎉TODO:
installGlobals
in userland)