Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass useMatches objects to ScrollRestoration getKey #9157

Merged
merged 4 commits into from
Aug 18, 2022

Conversation

brophdawg11
Copy link
Contributor

<ScrollRestoration getKey> should get the "public" matches from useMatches instead of the internal router matches objects

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2022

🦋 Changeset detected

Latest commit: 89a1f37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
react-router-dom Patch
@remix-run/router Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit 5c8fdec into dev Aug 18, 2022
@brophdawg11 brophdawg11 deleted the brophdawg11/scroll-key-matches branch August 18, 2022 13:52
brophdawg11 added a commit that referenced this pull request Apr 23, 2024
Co-authored-by: Sergio Xalambrí <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant