-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added better detection for absolute urls in link component #9994
Conversation
🦋 Changeset detectedLatest commit: 9400e9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Huh, yeah we had switched this |
@lkwr Do you mind adding a changeset to this PR via |
7966cf0
to
9400e9a
Compare
This is fixed in |
I just tested it and it works like a charm. |
This merge request improves the detection of absolute URLs in the
<Link to=".." />
component.Before this merge request:
<Link to="mailto:[email protected]" />
will not solve to the correct url because its detected as a relative url.After this merge request:
<Link to="mailto:[email protected]" />
will solve to the correct url and opens the mail app depending on the browser.This uses the same regex as in #9829