chore(remix-dev): don't allow * to be anywhere in segment (#5014)

* chore(remix-dev): don't allow * to be anywhere in segment Signed-off-by: Logan McAnsh <[email protected]> * Create little-lobsters-decide.md Signed-off-by: Logan McAnsh <[email protected]>
remix-run · Jan 5, 2023 · 45d4491 · 45d4491
1 parent 5663081
commit 45d4491
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/.changeset/little-lobsters-decide.md b/.changeset/little-lobsters-decide.md
@@ -0,0 +1,6 @@
+---
+"remix": patch
+"@remix-run/dev": patch
+---
+
+don't allow `*` to be anywhere in flat route segment
diff --git a/packages/remix-dev/__tests__/flat-routes-test.ts b/packages/remix-dev/__tests__/flat-routes-test.ts
@@ -109,6 +109,7 @@ describe("flatRoutes", () => {
     let invalidSplatFiles: string[] = [
       "routes/about.[*].tsx",
       "routes/about.*.tsx",
+      "routes/about.[.[.*].].tsx",
     ];
 
     for (let invalid of invalidSplatFiles) {
@@ -369,14 +370,6 @@ describe("flatRoutes", () => {
           path: ".",
         },
       ],
-      [
-        "routes/about.[.[.*].].tsx",
-        {
-          id: "routes/about.[.[.*].]",
-          parentId: "routes/about",
-          path: ".[.*/]",
-        },
-      ],
 
       // Optional route segments
       [

diff --git a/packages/remix-dev/config/flat-routes.ts b/packages/remix-dev/config/flat-routes.ts
@@ -133,7 +133,7 @@ export function getRouteSegments(routeId: string) {
       );
     };
 
-    if (rawRouteSegment === "*") {
+    if (rawRouteSegment.includes("*")) {
       return notSupportedInRR(rawRouteSegment, "*");
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -133,7 +133,7 @@ export function getRouteSegments(routeId: string) { @@
           );
         };
-        if (rawRouteSegment === "*") {
+        if (rawRouteSegment.includes("*")) {
           return notSupportedInRR(rawRouteSegment, "*");
         }
@@ Expand Down @@