fix(remix-dev): fix override from user config

remix-run · Feb 2, 2023 · 5a1fe1d · 5a1fe1d
1 parent a01667b
commit 5a1fe1d
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/packages/remix-dev/config.ts b/packages/remix-dev/config.ts
@@ -388,27 +388,28 @@ export async function readConfig(
   let serverConditions = appConfig.serverConditions;
   let serverDependenciesToBundle = appConfig.serverDependenciesToBundle || [];
   let serverEntryPoint = appConfig.server;
-  let serverMainFields = appConfig.serverMainFields || ["main", "module"];
-  let serverMinify = appConfig.serverMinify || false;
+  let serverMainFields = appConfig.serverMainFields;
+  let serverMinify = appConfig.serverMinify;
   let serverModuleFormat = appConfig.serverModuleFormat || "cjs";
   let serverPlatform = appConfig.serverPlatform || "node";
   if (isCloudflareRuntime) {
-    serverConditions = ["worker"];
+    serverConditions ??= ["worker"];
     serverDependenciesToBundle = "all";
-    serverMainFields = ["browser", "module", "main"];
-    serverMinify = true;
+    serverMainFields ??= ["browser", "module", "main"];
+    serverMinify ??= true;
     serverModuleFormat = "esm";
     serverPlatform = "neutral";
   }
   if (isDenoRuntime) {
-    serverConditions = ["deno", "worker"];
+    serverConditions ??= ["deno", "worker"];
     serverDependenciesToBundle = "all";
-    serverMainFields = ["module", "main"];
+    serverMainFields ??= ["module", "main"];
     serverModuleFormat = "esm";
     serverPlatform = "neutral";
   }
-  serverMainFields ||=
+  serverMainFields ??=
     serverModuleFormat === "esm" ? ["module", "main"] : ["main", "module"];
+  serverMinify ??= false;
 
   let mdx = appConfig.mdx;