fix(dev): only do hmr for unstable_dev

remix-run · Feb 9, 2023 · d7e9b60 · d7e9b60
1 parent 9fad1ad
commit d7e9b60
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/packages/remix-dev/compiler/compileBrowser.ts b/packages/remix-dev/compiler/compileBrowser.ts
@@ -127,7 +127,7 @@ const createEsbuildConfig = (
     NodeModulesPolyfillPlugin(),
   ].filter(isNotNull);
 
-  if (mode === "development") {
+  if (mode === "development" && config.future.unstable_dev) {
     // TODO do this for all deps in package.json
     entryPoints["react"] = "react";
     entryPoints["react-dom"] = "react-dom";
@@ -301,7 +301,7 @@ export const createBrowserCompiler = (
     ]);
 
     let hmr: AssetsManifest["hmr"] | undefined = undefined;
-    if (options.mode === "development") {
+    if (options.mode === "development" && remixConfig.future.unstable_dev) {
       let hmrRuntimeOutput = Object.entries(metafile.outputs).find(
         ([_, output]) => output.inputs["hmr-runtime:remix:hmr"]
       )?.[0];

diff --git a/packages/remix-dev/compiler/plugins/browserRouteModulesPlugin.ts b/packages/remix-dev/compiler/plugins/browserRouteModulesPlugin.ts
@@ -39,15 +39,17 @@ export function browserRouteModulesPlugin(
 
           let contents = removeServerExports(sourceCode, routeFile, onLoader);
 
-          contents = await applyHMR(
-            contents,
-            {
-              ...args,
-              path: routeFile,
-            },
-            config,
-            !!build.initialOptions.sourcemap
-          );
+          if (config.future.unstable_dev) {
+            contents = await applyHMR(
+              contents,
+              {
+                ...args,
+                path: routeFile,
+              },
+              config,
+              !!build.initialOptions.sourcemap
+            );
+          }
 
           return {
             contents,