fix(remix-server-runtime): fix invalid character error in cookie serialize

[aiji42]

Fixed a bug that caused an error when cookie serializing data containing non-ascii characters.

• Tests

Closes #1282
Closes #2255

[mkrtchian]

A similar PR exists as #1290, related to issue #1282

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[aiji42]

@mkrtchian Thanks for letting me know. I did not know that.
This PR takes a different approach (smaller size of the encoded result) than that one. I will leave it to the development team and community to decide which one to adopt.

#1290 (comment)

[mjackson]

One thing we need to be careful about: I'm not sure if all the JS runtimes we support will have escape and unescape because they are currently in Annex B of ECMA-262 which states that we "should not use or assume the existence of these features and behaviors when writing new ECMAScript code".

The main other runtimes I'm concerned about at this point are Cloudflare and Deno, both of which we have support for. Polyfilling the environment is totally something we can do, I just want to make sure we have test coverage for both before merging something like this.

[aiji42]

@mjackson Thanks for the follow up.

Polyfilling the environment is totally something we can do, I just want to make sure we have test coverage for both before merging something like this.

Does this mean specifically that I should use the alternative code (see core-js) instead of using escape and unescape? Or are you asking me to create samples that runs on both Deno and Cloudflare, test it, and present it?
If you give me specific instructions, I will start working immediately.

[aiji42]

I haven't received a reply yet, but I polyfilled escape and unescape with reference to the core-js code. If the policy is different, please tell me. Withdraw the last commit.

[github-actions]

🤖 Hello there,

We just published version v1.3.5-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!