chore(examples/theme-ui): fix styling

[scottybrown]

We expect the theme-ui example's pages to have a stark blue background, to demonstrate that the theme-ui theme is being applied.

Instead, it has no styling at all.

The cause is this PR, which removes some lines which are fundamental to how theme-ui works.

I have also removed 2 entries from a useEffect dependency array which were also added in the mentioned PR, which were causing repeated Maximum update depth exceeded to appear in the browser console. This does not seem to affect this example, but can cause UI hangs on apps with state.

I've been unsuccessful in running linting against this example, so I can't verify whether my changes have brought back lint warnings. But they've certainly made the example more useful :)

Testing Strategy:

• Test that blue background appears on / and /jokes/
• Test that maximum update depth exceeded does not repeatedly appear in browser console

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4781dcd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[remix-cla-bot]

Hi @scottybrown,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[scottybrown]

This fix involves using useCallback so that reset is a stable reference for the dependency array. And removing the code that was writing straight to emotionCache without using state.
My testing found that this code is not required for either client or server side styling. It looks like it was taken from this Saas UI example, perhaps unnecessarily.

[kentcdodds]

Thank you!