-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(tutorial/jokes): fix typo #3962
Conversation
|
Hi @shairez, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
@shairez Please sign the CLA in order to get this merged. |
to be able to merge the smallest of the PRs :)
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Co-authored-by: Michaël De Boey <[email protected]>
Co-authored-by: Michaël De Boey <[email protected]>
@MichaelDeBoey took me a while, but now it's done :) |
Thank you @shairez ! |
Co-authored-by: Michaël De Boey <[email protected]>
Co-authored-by: Michaël De Boey <[email protected]>
Closes: #
The
:jokeId
and$jokeId
convention is confusing.The tutorial shows
/jokes/:jokeId
but then talks about$jokeId
referring to what we just saw.It looks like a typo