Skip script rendering after hydration

[developit]

This is a small tweak to @jacob-ebey's #403 that removes the window property. It achieves the same result as #390 but with minimal changes to Remix and no hydration mismatch concerns. Remix's components module is only instantiated once, so a module variable is sufficient for tracking isHydrated state.

[remix-cla-bot]

Hi @developit,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[ryanflorence]

Can ya'll help me understand what this is solving? The script entries only ever render once and then they never change because of the useMemo. Why do we need to remove them from the page after hydration?

[developit]

@ryanflorence the script elements do re-render when the whole tree gets remounted due to an error or redirect. Memoization doesn't help there.

The reason for this PR is because Preact doesn't emulate parser-created <script>, so rendering these on the client (barring during hydration) executes the new scripts.

[ryanflorence]

well crap ... tests pass locally for me