Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(remix-testing): remove internal installGlobals #4755

Merged
merged 5 commits into from
Dec 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/quick-cats-fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"remix": patch
"@remix-run/testing": patch
---

remove internal `installGlobals` function now that `@remix-run/web-form-data` includes support for passing a `HTMLFormElement`
13 changes: 13 additions & 0 deletions packages/remix-testing/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Welcome to Remix!

[Remix](https://remix.run) is a web framework that helps you build better websites with React.

To get started, open a new shell and run:

```sh
npx create-remix@latest
```

Then follow the prompts you see in your terminal.

For more information about Remix, [visit remix.run](https://remix.run)!
1 change: 0 additions & 1 deletion packages/remix-testing/index.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
export { createRemixStub as unstable_createRemixStub } from "./create-remix-stub";
export { installGlobals as unstable_installGlobals } from "./install-globals";
22 changes: 0 additions & 22 deletions packages/remix-testing/install-globals.ts

This file was deleted.

3 changes: 0 additions & 3 deletions packages/remix-testing/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,9 @@
"react-dom": "^18.2.0"
},
"devDependencies": {
"@types/jsdom": "^20.0.1",
"@types/node": "^18.11.9",
"@types/react": "^18.0.24",
"@types/react-dom": "^18.0.8",
"happy-dom": "^7.7.0",
"jsdom": "^20.0.3",
"typescript": "^4.8.4"
},
"engines": {
Expand Down
Loading