Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(file-conventions/routes-files): Fix headers link #5545

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

alanhoskins
Copy link
Contributor

  • Docs

The link to headers in the Route File Naming was pointing to https://remix.run/docs/en/v1/routes/headers when it should have been point to https://remix.run/docs/en/v1/route/headers

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023

⚠️ No Changeset found

Latest commit: 3576a83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 23, 2023

Hi @alanhoskins,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 23, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@github-actions
Copy link
Contributor

This PR has been automatically marked stale because we haven't received a response from the original author in a while 🙈. This automation helps keep the issue tracker clean from issues that are not actionable. Please reach out if you have more information for us or you think this issue shouldn't be closed! 🙂 If you don't do so within 7 days, this PR will be automatically closed.

@github-actions github-actions bot added the needs-response We need a response from the original author about this issue/PR label Apr 24, 2023
@kiliman
Copy link
Collaborator

kiliman commented Apr 24, 2023

This is still a typo in the docs so this PR should be merged.

@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label Apr 24, 2023
@machour machour changed the title Fix the link to headers in Route File Naming docs(file-conventions/routes-files): Fix headers link Apr 26, 2023
Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@machour machour merged commit 20c8e84 into remix-run:main Apr 26, 2023
@machour machour added the docs label Apr 26, 2023
@alanhoskins alanhoskins deleted the fix-routes-docs branch April 26, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants