-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(pages/v2): remove default values from serverBuildTarget
section
#5976
docs(pages/v2): remove default values from serverBuildTarget
section
#5976
Conversation
|
bfe094d
to
ad37113
Compare
I think the default values can be helpful in this context so you know the full extent of what the old thing was doing for you. The main docs on |
@brophdawg11 What about adding them as comments instead then? |
Something like this? serverModuleFormat: "cjs", // default value, can be removed @jacob-ebey what do you think? |
ad37113
to
9c89428
Compare
@MichaelDeBoey, let's leave the values in the config but add the comment next to them for now like @brophdawg11 suggested. |
9c89428
to
97ec15e
Compare
@brophdawg11 @jacob-ebey I've updated this PR as requested 👍 |
97ec15e
to
1f71fcd
Compare
Follow-up of #5934
Since we're talking about replacement, I figured that we don't need to specify the default values in here in order to make it work as expected