Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pages/v2): remove default values from serverBuildTarget section #5976

Conversation

MichaelDeBoey
Copy link
Member

Follow-up of #5934

Since we're talking about replacement, I figured that we don't need to specify the default values in here in order to make it work as expected

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2023

⚠️ No Changeset found

Latest commit: 1f71fcd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey force-pushed the remove-default-values-from-serverBuildTarget-section-in-v2-docs branch 2 times, most recently from bfe094d to ad37113 Compare April 10, 2023 17:07
@brophdawg11
Copy link
Contributor

I think the default values can be helpful in this context so you know the full extent of what the old thing was doing for you. The main docs on remix.config.js do include the defaults so folks can figure out if they need all these fields if they want to?

@MichaelDeBoey
Copy link
Member Author

@brophdawg11 What about adding them as comments instead then?
I just don't want people to think they need to include all these values in order to make it work.

@brophdawg11
Copy link
Contributor

Something like this?

serverModuleFormat: "cjs", // default value, can be removed

@jacob-ebey what do you think?

@MichaelDeBoey MichaelDeBoey force-pushed the remove-default-values-from-serverBuildTarget-section-in-v2-docs branch from ad37113 to 9c89428 Compare April 13, 2023 20:03
@jacob-ebey
Copy link
Member

@MichaelDeBoey, let's leave the values in the config but add the comment next to them for now like @brophdawg11 suggested.

@MichaelDeBoey MichaelDeBoey force-pushed the remove-default-values-from-serverBuildTarget-section-in-v2-docs branch from 9c89428 to 97ec15e Compare April 14, 2023 00:47
@MichaelDeBoey
Copy link
Member Author

@brophdawg11 @jacob-ebey I've updated this PR as requested 👍

@MichaelDeBoey MichaelDeBoey force-pushed the remove-default-values-from-serverBuildTarget-section-in-v2-docs branch from 97ec15e to 1f71fcd Compare April 14, 2023 16:17
@MichaelDeBoey MichaelDeBoey merged commit b33dcda into remix-run:main Apr 17, 2023
@MichaelDeBoey MichaelDeBoey deleted the remove-default-values-from-serverBuildTarget-section-in-v2-docs branch April 17, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants