-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
templates(cloudflare-pages): ignore .dev.vars
instead of .env
#6024
Conversation
|
Hi @yudai-nkt, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
Hi Remix team, at which line should I sign? Contributors' names look alphabetically sorted basically but the last 3 lines are not the cases. |
.dev.vars
instead of .env
@yudai-nkt You can just add your name to the end of the file. CI will place them in alphabetical order. |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
@MichaelDeBoey thanks for the answer and that's cool! Now I've signed. |
This isn't a simple docs change but is still a small change in template, so I deleted the PR form you prepared. Let me know if that is inconvenient for you.
As is documented here, Cloudflare Pages uses
.dev.vars
for storing environment variables instead of.env
. So ignoring.env
isn't really helpful for Pages template.