Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates(cloudflare-pages): ignore .dev.vars instead of .env #6024

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

yudai-nkt
Copy link
Contributor

This isn't a simple docs change but is still a small change in template, so I deleted the PR form you prepared. Let me know if that is inconvenient for you.

As is documented here, Cloudflare Pages uses .dev.vars for storing environment variables instead of .env. So ignoring .env isn't really helpful for Pages template.

@changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2023

⚠️ No Changeset found

Latest commit: b666e74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 9, 2023

Hi @yudai-nkt,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@yudai-nkt
Copy link
Contributor Author

yudai-nkt commented Apr 9, 2023

Hi Remix team, at which line should I sign? Contributors' names look alphabetically sorted basically but the last 3 lines are not the cases.

@MichaelDeBoey MichaelDeBoey changed the title chore(templates/cloudflare-pages): ignore .dev.vars instead of .env templates(cloudflare-pages): ignore .dev.vars instead of .env Apr 10, 2023
@MichaelDeBoey
Copy link
Member

@yudai-nkt You can just add your name to the end of the file. CI will place them in alphabetical order.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 11, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@yudai-nkt
Copy link
Contributor Author

@MichaelDeBoey thanks for the answer and that's cool! Now I've signed.

@MichaelDeBoey MichaelDeBoey merged commit df751e9 into remix-run:main Apr 11, 2023
@yudai-nkt yudai-nkt deleted the ignore-dev-vars branch April 13, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants