Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: add css-bundle boilerplate #6110

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

markdalgleish
Copy link
Member

Since we're enabling CSS bundling features in v1.16, this ensures that the boilerplate is already present. This is particularly important for CSS side-effect imports since consumers might install packages that import CSS without knowing that this boilerplate is necessary.

@markdalgleish markdalgleish requested a review from pcattori April 20, 2023 01:29
@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2023

⚠️ No Changeset found

Latest commit: 52a9df7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish changed the title chore: add css-bundle boilerplate to templates add css-bundle boilerplate to templates Apr 20, 2023
@markdalgleish markdalgleish requested a review from mcansh April 20, 2023 01:39
@markdalgleish markdalgleish merged commit 85c3cb6 into dev Apr 21, 2023
@markdalgleish markdalgleish deleted the markdalgleish/css-bundle-templates branch April 21, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants